Skip to content

Remove Workflow Actions from WorkflowEngine #78257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

saponifi3d
Copy link
Contributor

Description

This model was renamed to Action, which has already been added.

This model is being removed before it is accessible, so there isn't any data and we should be able to safely drop the table.

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Sep 27, 2024
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Sep 27, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
21681 2 21679 208
View the top 2 failed tests by shortest run time
tests.sentry.backup.test_releases.ReleaseTests test_at_head
Stack Traces | 50s run time
#x1B[1m#x1B[.../sentry/backup/test_releases.py#x1B[0m:90: in test_at_head
    self.insta_snapshot(
#x1B[1m#x1B[.../testutils/pytest/fixtures.py#x1B[0m:245: in inner
    is_unequal = inequality_comparator(refval, output)
#x1B[1m#x1B[.../sentry/backup/test_releases.py#x1B[0m:55: in snapshot_inequality_comparator
    result = validate(refval_json, output_json, get_default_comparators())
#x1B[1m#x1B[.../sentry/backup/validate.py#x1B[0m:183: in validate
    left_models, left_ordinal_counters = build_model_map(left_data, Side.left, findings)
#x1B[1m#x1B[.../sentry/backup/validate.py#x1B[0m:108: in build_model_map
    raise RuntimeError("Unknown model class")
#x1B[1m#x1B[31mE   RuntimeError: Unknown model class#x1B[0m
tests.sentry.backup.test_releases.ReleaseTests test_at_head
Stack Traces | 58.8s run time
#x1B[1m#x1B[.../sentry/backup/test_releases.py#x1B[0m:90: in test_at_head
    self.insta_snapshot(
#x1B[1m#x1B[.../testutils/pytest/fixtures.py#x1B[0m:245: in inner
    is_unequal = inequality_comparator(refval, output)
#x1B[1m#x1B[.../sentry/backup/test_releases.py#x1B[0m:55: in snapshot_inequality_comparator
    result = validate(refval_json, output_json, get_default_comparators())
#x1B[1m#x1B[.../sentry/backup/validate.py#x1B[0m:183: in validate
    left_models, left_ordinal_counters = build_model_map(left_data, Side.left, findings)
#x1B[1m#x1B[.../sentry/backup/validate.py#x1B[0m:108: in build_model_map
    raise RuntimeError("Unknown model class")
#x1B[1m#x1B[31mE   RuntimeError: Unknown model class#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@saponifi3d saponifi3d force-pushed the jcallender/aci-remove-workflow-actions branch from 045583a to 1ad5acc Compare September 27, 2024 17:20
@saponifi3d saponifi3d changed the base branch from jcallender/aci-detector-state to master September 27, 2024 17:20
@saponifi3d saponifi3d marked this pull request as ready for review September 27, 2024 17:22
@saponifi3d saponifi3d requested a review from a team September 27, 2024 17:22
@saponifi3d saponifi3d requested a review from a team as a code owner September 27, 2024 17:22
@saponifi3d saponifi3d requested a review from a team September 27, 2024 17:24
@saponifi3d saponifi3d closed this Sep 27, 2024
saponifi3d added a commit that referenced this pull request Sep 27, 2024
## Description
Pre-req for #78257 to be able to remove the workflow actions table.
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant