feat(angular-onboarding): Add standalone app docs #77302
Conversation
github-actions
bot
added
the
Scope: Frontend
| label: t('App Type'), | ||
| defaultValue: AppType.STANDALONE, | ||
| items: [ | ||
| { | ||
| label: 'Standalone', | ||
| value: AppType.STANDALONE, | ||
| }, | ||
| { | ||
| label: 'Module', | ||
| value: AppType.MODULE, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
@Lms24 what would be the proper label for it?
Can we add some postfix to Standalone and Module to make it clearer?
There was a problem hiding this comment.
With "postfix", do you mean a tootlip-like element? Then I'd add something like
- standalone: "Use this if you have an
app.config.tsfile" - module: "Use this if you have an
app.module.tsfile"
Some other ideas for the button names:
- App Config / App Module
- Standalone Config / Module-based Config
- Standalone Config / NGModule Config
- App Config / NGModule Config
- Standalone Conponent Config / NGModule-based Config
After thinking a bit about it, I kinda like 3 and 4. Makes it really clear that we're talking about Angular's NGModules. WDYT?
There was a problem hiding this comment.
Or can we do something like
"I have an [app.config.ts]|[app.module.ts] file", so that the selection more or less becomes part of a sentence? Hope this makes sense 😅
There was a problem hiding this comment.
Was talking about changing the button label 👍
Will go with 4 then. that is the clearest for me as someone who is not super familiar with Angular.
|
|
||
| const appInit = isModuleApp(params) | ||
| ? ` | ||
| enableProdMode(); |
There was a problem hiding this comment.
@Lms24 Why are we suggesting to enable prod mode?
According to the Angular docs this is discouraged. Maybe this deserves a comment?
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77302 +/- ##
===========================================
+ Coverage 57.38% 78.09% +20.71%
===========================================
Files 6945 6944 -1
Lines 308220 307754 -466
Branches 50449 50385 -64
===========================================
+ Hits 176883 240353 +63470
+ Misses 126537 61036 -65501
- Partials 4800 6365 +1565 |
ArthurKnaus
deleted the
aknaus/feat/angular-onboarding/add-standalone-app-docs
branch
Add platform option to
javascript-angularthat allows to switch between standalone / module app initialization.Screen.Recording.2024-09-11.at.11.32.54.mov
Closes #77134