-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
build(ui): Add rspack as webpack alternative #77077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # build-utils/last-built-plugin.ts # config/rspack.chartcuterie.config.ts # package.json # rspack.config.ts # yarn.lock
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
|
# Conflicts: # package.json # rspack.config.ts # yarn.lock
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
# Conflicts: # package.json
# Conflicts: # package.json # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slam it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those HMR numbers look 🔥
supported_locales: string[]; | ||
}; | ||
|
||
const localeCatalog: LocaleCatalog = JSON.parse( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of the scope of this PR, but it would be interesting if we could time this locale procedure to see how much it contributes to the startup cost.
Building off the work done in #61475 I think the plan would be to use this as a dev-ui replacement until we're more confident and can setup the getsentry repo as well (if you aren't familiar we have another repo with billing pages etc).
Potential adoption roadmap
Summary
RSPACK + SENTRY TODO (updated Oct 7th, 2024)
autoLabel: 'always',
Could just set label setting based on node_env.make build-js-po
Thanks @hardfist for helping with this PR!