-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(issues): Don't treat %s as unique #75090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
If an event already has a parameterized logentry message, ensure that uniq_id doesn't try to treat the %s as unique.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #75090 +/- ##
===========================================
+ Coverage 57.05% 78.12% +21.07%
===========================================
Files 6735 6748 +13
Lines 300698 301174 +476
Branches 51732 51810 +78
===========================================
+ Hits 171551 235301 +63750
+ Misses 124394 59542 -64852
- Partials 4753 6331 +1578
|
return False # Don't replace short tokens | ||
if token_str[0] == "<" and token_str[-1] == ">": | ||
return False # Don't replace already-parameterized tokens | ||
if "%s" in token_str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason not to add %d
in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a combination of the difficulty in testing this and I want to limit the amount of additional work we have do do on each token_str
until we have a better way to do better performance testing as well
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
If an event already has a parameterized
logentry.message
, ensure that uniq_id doesn't try to treat the %s as unique.Example event payload:
Prior to this change, these would have been parameterized as
Hard time limit (%ss) exceeded for <uniq_id>
(internal example).This is currently pretty hard to test end-to-end and is also only catching a subset of possible
%
replacements, will follow up with a future PR to improve that but for now this will address the most common case.Reminder: this parameterization is still only enabled experimentally and is not widely released.