Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(grouping): Use a dataclass for seer grouping request typing #69934

Conversation

lobsterkatie
Copy link
Member

This switches to using a dataclass for typing requests to seer for similar groups, primarily to make it easier to handle optional attributes.

In the long run, we might consider switching the typing for other associated types to dataclasses as well, for consistency, but to keep things simple for now I'm just switching this one since it's the only one with optional fields.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (ff214bb) to head (59823b5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #69934      +/-   ##
==========================================
- Coverage   79.85%   79.85%   -0.01%     
==========================================
  Files        6490     6490              
  Lines      288620   288622       +2     
  Branches    49699    49700       +1     
==========================================
- Hits       230488   230484       -4     
- Misses      57734    57740       +6     
  Partials      398      398              
Files Coverage Δ
...y/api/endpoints/group_similar_issues_embeddings.py 100.00% <100.00%> (ø)
src/sentry/seer/utils.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@lobsterkatie
Copy link
Member Author

Closing this in favor of #70070.

@lobsterkatie lobsterkatie deleted the kmclb-use-dataclass-for-seer-grouping-request-type branch May 6, 2024 19:59
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant