Skip to content

hybridcloud: add hashed_token to apitokenreplica #66679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented Mar 11, 2024

Add hashed_token to ApiTokenReplica.

Prerequisite for #65941

@mdtro mdtro requested a review from a team as a code owner March 11, 2024 11:16
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 11, 2024
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/hybridcloud/migrations/0014_apitokenreplica_add_hashed_token.py ()

--
-- Add field hashed_token to apitokenreplica
--
ALTER TABLE "hybridcloud_apitokenreplica" ADD COLUMN "hashed_token" varchar(128) NULL;

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.29%. Comparing base (3138e84) to head (78fbc78).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #66679      +/-   ##
==========================================
+ Coverage   84.26%   84.29%   +0.03%     
==========================================
  Files        5283     5307      +24     
  Lines      236948   237142     +194     
  Branches    41011    41011              
==========================================
+ Hits       199657   199909     +252     
+ Misses      37072    37014      -58     
  Partials      219      219              
Files Coverage Δ
...igrations/0014_apitokenreplica_add_hashed_token.py 100.00% <100.00%> (ø)
src/sentry/hybridcloud/models/apitokenreplica.py 97.50% <100.00%> (+0.06%) ⬆️

... and 40 files with indirect coverage changes

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Column matches the source table.

@mdtro mdtro merged commit 744d9c7 into master Mar 12, 2024
@mdtro mdtro deleted the mdtro/apitokenreplica-hashed-token branch March 12, 2024 08:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants