feat(processing): Enable Node.js Source Maps

src/sentry/interfaces/stacktrace.py

@@ -537,7 +537,7 @@ def get_culprit_string(self, platform=None):
         fileloc = self.module or self.filename
         if not fileloc:
             return ''
-        elif platform == 'javascript':
+        elif platform in ('javascript', 'node'):
             # function and fileloc might be unicode here, so let it coerce
             # to a unicode string if needed.
             return '%s(%s)' % (self.function or '?', fileloc)

src/sentry/lang/javascript/plugin.py

@@ -12,7 +12,8 @@
 def preprocess_event(data):
     rewrite_exception(data)
     fix_culprit(data)
-    inject_device_data(data)
+    if data.get('platform') == 'javascript':
+        inject_device_data(data)
     generate_modules(data)
     return data
 
@@ -23,7 +24,7 @@ def generate_modules(data):
     for info in find_stacktraces_in_data(data):
         for frame in info.stacktrace['frames']:
             platform = frame.get('platform') or data['platform']
-            if platform != 'javascript' or frame.get('module'):
+            if platform not in ('javascript', 'node') or frame.get('module'):
                 continue
             abs_path = frame.get('abs_path')
             if abs_path and abs_path.startswith(('http:', 'https:', 'webpack:', 'app:')):
@@ -129,10 +130,10 @@ def can_configure_for_project(self, project, **kwargs):
     def get_event_preprocessors(self, data, **kwargs):
         # XXX: rewrite_exception we probably also want if the event
         # platform is something else? unsure
-        if data.get('platform') == 'javascript':
+        if data.get('platform') in ('javascript', 'node'):
             return [preprocess_event]
         return []
 
     def get_stacktrace_processors(self, data, stacktrace_infos, platforms, **kwargs):
-        if 'javascript' in platforms:
+        if 'javascript' in platforms or 'node' in platforms:
             return [JavaScriptStacktraceProcessor]

src/sentry/lang/javascript/processor.py

@@ -56,7 +56,7 @@ class ZeroReturnError(Exception):
 VERSION_RE = re.compile(r'^[a-f0-9]{32}|[a-f0-9]{40}$', re.I)
 NODE_MODULES_RE = re.compile(r'\bnode_modules/')
 SOURCE_MAPPING_URL_RE = re.compile(r'\/\/# sourceMappingURL=(.*)$')
-# the maximum number of remote resources (i.e. sourc eifles) that should be
+# the maximum number of remote resources (i.e. source files) that should be
 # fetched
 MAX_RESOURCE_FETCHES = 100
 
@@ -495,7 +495,7 @@ def preprocess_step(self, processing_task):
 
     def handles_frame(self, frame, stacktrace_info):
         platform = frame.get('platform') or self.data.get('platform')
-        return (settings.SENTRY_SCRAPE_JAVASCRIPT_CONTEXT and platform == 'javascript')
+        return (settings.SENTRY_SCRAPE_JAVASCRIPT_CONTEXT and platform in ('javascript', 'node'))
 
     def preprocess_frame(self, processable_frame):
         # Stores the resolved token.  This is used to cross refer to other
@@ -517,6 +517,13 @@ def process_frame(self, processable_frame, processing_task):
         if not frame.get('abs_path') or not frame.get('lineno'):
             return
 
+        # can't fetch if this is internal node module as well
+        # therefore we only process user-land frames (starting with /)
+        # or those created by bundle/webpack internals
+        if self.data.get('platform') == 'node' and \
+                not frame.get('abs_path').startswith(('/', 'app:', 'webpack:')):
+            return
+
         errors = cache.get_errors(frame['abs_path'])
         if errors:
             all_errors.extend(errors)
@@ -588,7 +595,7 @@ def process_frame(self, processable_frame, processing_task):
                 )
                 source = self.get_sourceview(abs_path)
 
-            if not source:
+            if source is None:
                 errors = cache.get_errors(abs_path)
                 if errors:
                     all_errors.extend(errors)
@@ -639,9 +646,14 @@ def process_frame(self, processable_frame, processing_task):
                     else:
                         filename = filename.split('webpack:///', 1)[-1]
 
-                    # As noted above, '~/' means they're coming from node_modules,
-                    # so these are not app dependencies
-                    if filename.startswith('~/'):
+                    # As noted above:
+                    # * [js/node] '~/' means they're coming from node_modules, so these are not app dependencies
+                    # * [node] sames goes for `./node_modules/`, which is used when bundling node apps
+                    # * [node] and webpack, which includes it's own code to bootstrap all modules and its internals
+                    #   eg. webpack:///webpack/bootstrap, webpack:///external
+                    if filename.startswith('~/') or \
+                            filename.startswith('./node_modules/') or \
+                            not filename.startswith('./'):
                         in_app = False
                     # And conversely, local dependencies start with './'
                     elif filename.startswith('./'):
@@ -791,6 +803,10 @@ def populate_source_cache(self, frames):
             # a fetch error that may be confusing.
             if f['abs_path'] == '<anonymous>':
                 continue
+            # we cannot fetch any other files than those uploaded by user
+            if self.data.get('platform') == 'node' and \
+                    not f.get('abs_path').startswith('app:'):
+                continue
             pending_file_list.add(f['abs_path'])
 
         for idx, filename in enumerate(pending_file_list):

src/sentry/models/featureadoption.py

@@ -50,7 +50,7 @@
 )
 manager.add(43, "user_tracking", "User Tracking", "code", prerequisite=["first_event"])
 manager.add(44, "custom_tags", "Custom Tags", "code", prerequisite=["first_event"])
-manager.add(45, "source_maps", "Source Maps", "code", prerequisite=["first_event", "javascript"])
+manager.add(45, "source_maps", "Source Maps", "code", prerequisite=["first_event", ("javascript", "node")])
 manager.add(46, "user_feedback", "User Feedback", "code", prerequisite=["user_tracking"])
 # manager.add(47, "api", "API", "code", prerequisite=["first_event"])  #
 # Challenging to determine what organization (i.e. api/0/organizations/)

src/sentry/models/organizationonboardingtask.py

@@ -26,7 +26,7 @@ class OnboardingTask(object):
     SECOND_PLATFORM = 4  # dependent on FIRST_EVENT.
     USER_CONTEXT = 5  # dependent on FIRST_EVENT
     RELEASE_TRACKING = 6  # dependent on FIRST_EVENT
-    SOURCEMAPS = 7  # dependent on RELEASE_TRACKING and one of the platforms being javascript
+    SOURCEMAPS = 7  # dependent on RELEASE_TRACKING and one of the platforms being javascript or node
     USER_REPORTS = 8  # Only for web frameworks
     ISSUE_TRACKER = 9
     NOTIFICATION_SERVICE = 10

src/sentry/utils/javascript.py

@@ -9,7 +9,7 @@
 
 
 def has_sourcemap(event):
-    if event.platform != 'javascript':
+    if event.platform not in ('javascript', 'node'):
         return False
     data = event.data