Skip to content

feat: add support for name on api token endpoints #64493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented Feb 2, 2024

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 2, 2024
@mdtro mdtro linked an issue Feb 2, 2024 that may be closed by this pull request
@mdtro mdtro requested review from ykamo001 and a team February 2, 2024 21:22
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37a4884) 78.79% compared to head (68fb9af) 81.35%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #64493      +/-   ##
==========================================
+ Coverage   78.79%   81.35%   +2.56%     
==========================================
  Files        5235     5236       +1     
  Lines      230926   230937      +11     
  Branches    45292    45293       +1     
==========================================
+ Hits       181947   187883    +5936     
+ Misses      42899    37212    -5687     
+ Partials     6080     5842     -238     
Files Coverage Δ
src/sentry/api/endpoints/api_tokens.py 100.00% <100.00%> (+26.22%) ⬆️
src/sentry/api/serializers/models/apitoken.py 94.73% <ø> (ø)

... and 478 files with indirect coverage changes

@mdtro mdtro merged commit 1f687b7 into master Feb 2, 2024
@mdtro mdtro deleted the mdtro/apitoken-name-be branch February 2, 2024 23:28
cmanallen pushed a commit that referenced this pull request Feb 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add name and token_last_characters to ApiToken
2 participants