-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apitoken last characters option #59455
Conversation
c263447
to
9b54c14
Compare
06ea00e
to
db8e691
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #59455 +/- ##
==========================================
- Coverage 80.76% 80.76% -0.01%
==========================================
Files 5179 5179
Lines 227404 227418 +14
Branches 38254 38255 +1
==========================================
+ Hits 183671 183679 +8
- Misses 38138 38144 +6
Partials 5595 5595
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to be extra careful, we should modify one of the two calls to ApiToken.objects.create(...)
in src/sentry/testutils/helpers/backups.py
to include token_last_characters
, while the other one continues writing null
. Then we get coverage for both options while we roll this out, to prevent breaking self-hosted users.
0df099c
to
fe6a9d2
Compare
30eaa6e
to
6120b76
Compare
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
token_last_characters
for theApiToken
model.This option will ensure tokens created from here on have the field populated. It will also allow me to thoroughly test the backfill migration needed for existing tokens that will be coming in a future PR by disabling the option in tests, creating a bunch of API tokens, and then running the backfill migration test.
Tracking Issue: #58918
RFC: getsentry/rfcs#32