-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(auth): oauth revoke endpoint #53809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
406a1f4
to
02898ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #53809 +/- ##
==========================================
+ Coverage 78.63% 79.97% +1.33%
==========================================
Files 5084 5035 -49
Lines 219211 214784 -4427
Branches 37119 36452 -667
==========================================
- Hits 172373 171766 -607
+ Misses 41255 37745 -3510
+ Partials 5583 5273 -310
|
02898ce
to
22e9802
Compare
22e9802
to
4dc3d4a
Compare
fc5a8b5
to
f97acd3
Compare
81a8208
to
0ae9dea
Compare
0d7b1f0
to
8b1cf9b
Compare
8b1cf9b
to
aae5788
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great :) Left some minor comments/questions. Thanks for doing this!
a5582a8
to
5979b6f
Compare
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
- add additional test coverage for error cases - align error responses with RFC 7009 Section 4.1.1 and RFC 6749 Section 5.2 - https://datatracker.ietf.org/doc/html/rfc7009#section-4.1.1 - https://datatracker.ietf.org/doc/html/rfc6749#section-5.2
3f17123
to
335e428
Compare
Implementation of the
/revoke
OAuth endpoint defined in RFC 7009 to allow confidential clients (ie. API Applications, Sentry Integrations, and Sentry Apps) to revoke access and refresh tokens.