Skip to content

feat(auth): oauth revoke endpoint #53809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

feat(auth): oauth revoke endpoint #53809

wants to merge 17 commits into from

Conversation

mdtro
Copy link
Member

@mdtro mdtro commented Jul 28, 2023

Implementation of the /revoke OAuth endpoint defined in RFC 7009 to allow confidential clients (ie. API Applications, Sentry Integrations, and Sentry Apps) to revoke access and refresh tokens.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 28, 2023
@mdtro mdtro force-pushed the mdtro/feat/oauth-revoke branch from 406a1f4 to 02898ce Compare July 28, 2023 22:27
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #53809 (44e7503) into master (626a71c) will increase coverage by 1.33%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head 44e7503 differs from pull request most recent head 1e6c00a. Consider uploading reports for the commit 1e6c00a to get more accurate results

@@            Coverage Diff             @@
##           master   #53809      +/-   ##
==========================================
+ Coverage   78.63%   79.97%   +1.33%     
==========================================
  Files        5084     5035      -49     
  Lines      219211   214784    -4427     
  Branches    37119    36452     -667     
==========================================
- Hits       172373   171766     -607     
+ Misses      41255    37745    -3510     
+ Partials     5583     5273     -310     
Files Changed Coverage
src/sentry/web/frontend/oauth_revoke.py 100.00%
src/sentry/web/urls.py 100.00%

@mdtro mdtro force-pushed the mdtro/feat/oauth-revoke branch from 02898ce to 22e9802 Compare August 8, 2023 18:31
@mdtro mdtro marked this pull request as ready for review August 8, 2023 18:33
@mdtro mdtro force-pushed the mdtro/feat/oauth-revoke branch from 22e9802 to 4dc3d4a Compare August 9, 2023 17:08
@mdtro mdtro force-pushed the mdtro/feat/oauth-revoke branch from fc5a8b5 to f97acd3 Compare August 9, 2023 21:27
@mdtro mdtro force-pushed the mdtro/feat/oauth-revoke branch from 81a8208 to 0ae9dea Compare August 10, 2023 16:28
@mdtro mdtro requested a review from a team August 15, 2023 22:21
@mdtro mdtro force-pushed the mdtro/feat/oauth-revoke branch from 0d7b1f0 to 8b1cf9b Compare August 15, 2023 22:21
@mdtro mdtro force-pushed the mdtro/feat/oauth-revoke branch from 8b1cf9b to aae5788 Compare August 16, 2023 18:09
Copy link
Contributor

@EricHasegawa EricHasegawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great :) Left some minor comments/questions. Thanks for doing this!

@mdtro mdtro marked this pull request as draft October 24, 2023 23:53
@getsantry
Copy link
Contributor

getsantry bot commented Nov 15, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 15, 2023
@getsantry getsantry bot closed this Nov 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
@mdtro mdtro reopened this Mar 7, 2024
@mdtro mdtro removed the Stale label Mar 7, 2024
@getsantry getsantry bot added the Stale label Mar 29, 2024
@mdtro mdtro added WIP and removed Stale labels Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants