feat(auth): oauth revoke endpoint #53809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mdtro
force-pushed
the
mdtro/feat/oauth-revoke
branch
from
406a1f4 to
02898ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #53809 +/- ##
==========================================
+ Coverage 78.63% 79.97% +1.33%
==========================================
Files 5084 5035 -49
Lines 219211 214784 -4427
Branches 37119 36452 -667
==========================================
- Hits 172373 171766 -607
+ Misses 41255 37745 -3510
+ Partials 5583 5273 -310
|
mdtro
force-pushed
the
mdtro/feat/oauth-revoke
branch
from
02898ce to
22e9802
Compare
mdtro
force-pushed
the
mdtro/feat/oauth-revoke
branch
from
22e9802 to
4dc3d4a
Compare
mdtro
force-pushed
the
mdtro/feat/oauth-revoke
branch
from
fc5a8b5 to
f97acd3
Compare
mdtro
force-pushed
the
mdtro/feat/oauth-revoke
branch
from
81a8208 to
0ae9dea
Compare
mdtro
force-pushed
the
mdtro/feat/oauth-revoke
branch
from
0d7b1f0 to
8b1cf9b
Compare
mdtro
force-pushed
the
mdtro/feat/oauth-revoke
branch
from
8b1cf9b to
aae5788
Compare
Contributor
EricHasegawa
left a comment
EricHasegawa
left a comment
There was a problem hiding this comment.
This looks great :) Left some minor comments/questions. Thanks for doing this!
mdtro
force-pushed
the
mdtro/feat/oauth-revoke
branch
from
a5582a8 to
5979b6f
Compare
Contributor
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
- add additional test coverage for error cases - align error responses with RFC 7009 Section 4.1.1 and RFC 6749 Section 5.2 - https://datatracker.ietf.org/doc/html/rfc7009#section-4.1.1 - https://datatracker.ietf.org/doc/html/rfc6749#section-5.2
mdtro
force-pushed
the
mdtro/feat/oauth-revoke
branch
from
3f17123 to
335e428
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the
/revokeOAuth endpoint defined in RFC 7009 to allow confidential clients (ie. API Applications, Sentry Integrations, and Sentry Apps) to revoke access and refresh tokens.