ref(loader): Streamline var usage #47316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
AbhiPrasad
approved these changes
Apr 13, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47316 +/- ##
===========================================
+ Coverage 61.37% 80.87% +19.49%
===========================================
Files 4738 4770 +32
Lines 201153 201584 +431
Branches 11542 11557 +15
===========================================
+ Hits 123465 163031 +39566
+ Misses 77433 38297 -39136
- Partials 255 256 +1 |
mydea
force-pushed
the
fn/use-loader-vars
branch
from
0b9259e to
2552ecc
Compare
mydea
force-pushed
the
fn/use-loader-vars
branch
from
2552ecc to
f57c96e
Compare
mydea
force-pushed
the
fn/use-loader-vars
branch
from
f57c96e to
a419f62
Compare
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 26, 2023
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 26, 2023
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 26, 2023
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Apr 27, 2023
mydea
force-pushed
the
fn/use-loader-vars
branch
from
a419f62 to
0d3abad
Compare
mydea
force-pushed
the
fn/use-loader-vars
branch
from
0d3abad to
1aa1404
Compare
AbhiPrasad
approved these changes
Apr 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update usage of the passed in variables, so we re-use strings as much as possible.