Skip to content

feat(replays): Add UI to display network request details #46219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Mar 28, 2023
Merged

feat(replays): Add UI to display network request details #46219

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9dbd854
feat(replays): Add UI to display network request details
ryan953 Mar 22, 2023
2f6a0cf
quick cleanup
ryan953 Mar 23, 2023
8db0f63
fixup splitDivider isHeld css, and make the new tabs work together wi…
ryan953 Mar 23, 2023
00f2b73
fix clicking on items in the table
ryan953 Mar 23, 2023
000dfd0
wip - fix useResizeableDrawer
ryan953 Mar 23, 2023
cce5676
tweaks
ryan953 Mar 23, 2023
1de7224
rm bonus changes
ryan953 Mar 23, 2023
22ea9be
fixup comments
ryan953 Mar 23, 2023
1ae1e06
Merge branch 'master' into ryan953/46054-req-res-main
ryan953 Mar 23, 2023
d12ce8f
better handling of empty req/resp data
ryan953 Mar 23, 2023
053ab00
trry to parse data into an object
ryan953 Mar 23, 2023
a6545fc
only show the details panel for xhr & fetch types
ryan953 Mar 23, 2023
b82f66a
add titles for sections
ryan953 Mar 23, 2023
1e6899b
drop headers tab, fix query param parsing
ryan953 Mar 23, 2023
d8bda1a
fix types
ryan953 Mar 23, 2023
604220c
fix onClick type
ryan953 Mar 24, 2023
151ae71
fix typo
ryan953 Mar 24, 2023
85023fb
rm JSON.parse call, show what we got
ryan953 Mar 24, 2023
dcf4014
make the content area a little wider, so the network details grabber …
ryan953 Mar 24, 2023
ea075c8
make TS happy
ryan953 Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quick cleanup
  • Loading branch information
@ryan953
ryan953 committed Mar 23, 2023
commit 2f6a0cfb39f59d3b4c01b23d38a2148d20f2a95f
14 changes: 9 additions & 5 deletions static/app/views/replays/detail/network/networkRequestDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {MouseEvent, useCallback, useMemo} from 'react';
import {Fragment, MouseEvent, useCallback, useMemo} from 'react';
import styled from '@emotion/styled';

import {Button} from 'sentry/components/button';
Expand Down Expand Up @@ -57,7 +57,7 @@ function NetworkRequestDetails({items}: Props) {
}

return (
<div data-test-id="network-request-details">
<Fragment>
<StyledStacked>
<StyledNetworkRequestTabs />
<CloseButtonWrapper>
Expand All @@ -79,7 +79,7 @@ function NetworkRequestDetails({items}: Props) {
<ResizeableContainer height={containerSize}>
<JSONBlock data={data} />
</ResizeableContainer>
</div>
</Fragment>
);
}

Expand Down Expand Up @@ -109,10 +109,14 @@ const StyledStacked = styled(Stacked)`
`;

const StyledNetworkRequestTabs = styled(NetworkRequestTabs)`
& > * {
& > li > a {
padding-top: ${space(1)};
padding-bottom: ${space(0.5)};
height: 100%;
border-bottom: ${space(0.5)} solid transparent;
}
& > :first-child {

& > li:first-child {
margin-left: ${space(1)};
}
`;
Expand Down