fix(perf-issues): Accept sanitized span descriptions #46187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL in the data is never different than the one in the description!
Clarify, and add handling for cases where span data has `http.query` information.
github-actions
bot
added
the
Scope: Backend
k-fish
approved these changes
Mar 22, 2023
gggritso
added a commit
that referenced
this pull request
Mar 22, 2023
This is an FE aspect of #46187. For N+1 API Call performance issues, we need to parse the URLs and extract the query parameters. With newer SDK versions, the query parameters might be in a separate key in span data called `http.query`, rather than being appended to the description or the `url` key in span data.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of getsentry/sentry-javascript#7206 the Node.js SDK will not append search parameters to the span's description or the URL. Instead, the search parameters will be in the
http.querykey. e.g.,{ "span_id": "a", "op": "http.client", "description": "GET /service", "http.query": "id=223" }This improves our URL handling to anticipate this case on the backend.