Remove the bookmarks filter if anon user #398 #444
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the "Only Bookmarks" filter from the sidebar * Ignore ?bookmarks=1 if anon user
Contributor
|
This seems like a good pull request. Sentry should never 500. Any idea on why this hasn't been merged? |
Member
|
I believe you have to be logged in now anyways so this is invalid |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to filter by bookmarks when not logged in currently fails hard (see #398)
This patch removes the "Only Bookmarks" link from the sidebar, and ignores
?bookmarks=1if the user is anonymous.I'm not convinced removing the link makes for a good UX. Perhaps disabling it in some way is a better option. Let me know what you guys prefer and I'll modify accordingly.