Pass missing keyword arguments to post_process_group #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit restores the post processor arguments dropped by 6a6afba, and prevents errors due to missing parameters from occurring during post processing.
dcramer
added a commit
that referenced
this pull request
Apr 18, 2012
Pass missing keyword arguments to post_process_group
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores the post processor arguments dropped by 6a6afba, and prevents errors due to missing parameters from occurring during post processing. This issue was especially devious if celery was disabled:
the resulting errors would cause logs of their own to be generated, generating more errors as post processing failed, and so on.