-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(tags): Allows tags endpoint to optionally return human readable values #40792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tags): Allows tags endpoint to optionally return human readable values #40792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but the 18k file sorta worries me, could we get some performance numbers using the timeit module (or sentry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include a comment in src/sentry/api/helpers/android_models.py
explaining how to update it? (ie. step 1 download file from ___, step 2 .... etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I've seen this mapping (or a similar mapping) before, maybe related to profiling? Are we sure we're not duplicating something that already exists?
I think there's been a link to some external mapping being shared on slack but none of that has been committed to the sentry repo yet from what I've been told. |
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Adds a
readable
option to the/tags
endpoint that includes more human readable values for certain tag values.For now, this is only supported by the
device
tag which converts device model numbers to their more readable marketing names.