Skip to content

chore(react): Make tooltipstore forward compatible with v17rc #20825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2020
Merged

chore(react): Make tooltipstore forward compatible with v17rc #20825

merged 2 commits into from
Sep 17, 2020

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Sep 16, 2020

Summary

Fixes the issue with tooltipStore not being forward compatible with v17, we can remove _reactInternalFiber in a separate PR after we upgrade.

@k-fish k-fish mentioned this pull request Sep 16, 2020
Closed
billyvg
billyvg approved these changes Sep 16, 2020
View reviewed changes
@github-actions
Copy link
Contributor

size-limit report

Path Size
public/app.js 234.73 KB (0%)
public/vendor.js 444.49 KB (0%)

@k-fish k-fish merged commit 326bf89 into master Sep 17, 2020
@k-fish k-fish deleted the chore/react-tooltipstore-forward-compatible branch September 17, 2020 00:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-fish @billyvg