Skip to content

feat: Remove ts-jest #13846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2019
Merged

feat: Remove ts-jest #13846

merged 1 commit into from
Jul 8, 2019

Conversation

dashed
Copy link
Member

@dashed dashed commented Jun 27, 2019

This was borrowed over from the Sentry JavaScript SDK.

We don't need ts-jest since we're likely not be writing tests in TypeScript.

In addition, we prefer to pipe jest tests through the babel pipeline rather than through ts-jest.

@dashed dashed requested review from HazAT and lynnagara June 27, 2019 18:27
Copy link
Member

@lynnagara lynnagara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dashed
Copy link
Member Author

dashed commented Jul 8, 2019

Going to merge this following a FE TSC meeting so folks won't have issues on their TypeScript adventures.

@dashed dashed merged commit 6704800 into master Jul 8, 2019
@dashed dashed deleted the remove-ts-jest branch July 8, 2019 19:10
jan-auer added a commit that referenced this pull request Jul 9, 2019
* master:
  chore: Fix typo errywhere -> everywhere (#13934)
  ref: (Django 1.9) Bump djangorestframework to 3.0.5 as an intermediate step to get to 3.3.x
  feat(issueless events): Test eventstream work without groups (#13888)
  ref: Improve repr of User (#13896)
  feat(loader): Make the default for new js projects v5 of js sdk (#13327)
  build: Remove browser-reload flag (#13918)
  ref(ui): Consolidate server frontend hydration logic (#13868)
  ref: Refactor user reports to not use Postgres Event (#13904)
  Test/integration acceptance tests (#13895)
  feat: Remove ts-jest (#13846)
  obs(sentry_apps): Add a small metrics increment on processing resource changes. (#13897)
  enable testing for all orgs (#13903)
  ref: Update Python SDK to 0.10.0 (#13911)
  fix: Do not suggest Sentry.Extensions.Logging when ASP.NET Core is used (#13891)
  Update license year to 2019
  ci(travis): Move docker-sentry builds to Dockes Hub autobuild (#13901)
  ref(app-platform): Add integration features to SentryAppDetailsModal (#13393)
  chore(ui) Rename OrganizationStream to IssueList (#13892)
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants