Skip to content

fix(ui) Fix overflowing tag values #13648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2019
Merged

fix(ui) Fix overflowing tag values #13648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/sentry/static/sentry/app/views/organizationEventsV2/tagsTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@ import {withRouter} from 'react-router';
import Link from 'app/components/links/link';
import {t} from 'app/locale';
import space from 'app/styles/space';
import overflowEllipsis from 'app/styles/overflowEllipsis';
import {getEventTagSearchUrl} from './utils';

const TagsTable = props => {
return (
<div>
<TagHeading>{t('Tags')}</TagHeading>
<table>
<StyledTable>
<tbody>
{props.tags.map(tag => (
<StyledTr key={tag.key}>
Expand All @@ -25,7 +26,7 @@ const TagsTable = props => {
</StyledTr>
))}
</tbody>
</table>
</StyledTable>
</div>
);
};
Expand All @@ -34,6 +35,12 @@ TagsTable.propTypes = {
location: PropTypes.object,
};

const StyledTable = styled('table')`
table-layout: fixed;
width: 100%;
max-width: 100%;
`;

const TagHeading = styled('h5')`
text-transform: uppercase;
color: ${p => p.theme.gray3};
Expand All @@ -55,6 +62,7 @@ const TagKey = styled('td')`

const TagValue = styled(TagKey)`
text-align: right;
${overflowEllipsis};
`;

export default withRouter(TagsTable);