Skip to content

fix(event-search): Ensure that project and issue are collections #13574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2019
+30 −3
Merged

fix(event-search): Ensure that project and issue are collections #13574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d19799
fix(event-search): Ensure that project and issue are collections
lynnagara Jun 6, 2019
86abe3c
fix
lynnagara Jun 6, 2019
aacb6fe
add test
lynnagara Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/sentry/api/event_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import absolute_import

import re
from collections import namedtuple
from collections import namedtuple, defaultdict
from datetime import datetime

import six
Expand Down Expand Up @@ -616,7 +616,7 @@ def get_snuba_query_args(query=None, params=None):

kwargs = {
'conditions': [],
'filter_keys': {},
'filter_keys': defaultdict(list),
}

for term in parsed_terms:
Expand All @@ -626,7 +626,10 @@ def get_snuba_query_args(query=None, params=None):
if snuba_name in ('start', 'end'):
kwargs[snuba_name] = term.value.value
elif snuba_name in ('project_id', 'issue'):
kwargs['filter_keys'][snuba_name] = term.value.value
value = term.value.value
if isinstance(value, int):
value = [value]
kwargs['filter_keys'][snuba_name].extend(value)
else:
converted_filter = convert_search_filter_to_snuba_query(term)
kwargs['conditions'].append(converted_filter)
Expand Down
24 changes: 24 additions & 0 deletions tests/sentry/api/test_event_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,6 +1124,30 @@ def test_boolean_term_simple(self):
'has_boolean_terms': True,
}

def test_issue_filter(self):
assert get_snuba_query_args('issue.id:1') == {
'conditions': [],
'filter_keys': {
'issue': [1],
},
}

assert get_snuba_query_args('issue.id:1 issue.id:2 issue.id:3') == {
'conditions': [],
'filter_keys': {
'issue': [1, 2, 3],
},
}

assert get_snuba_query_args('issue.id:1 user.email:foo@example.com') == {
'conditions': [
['email', '=', 'foo@example.com']
],
'filter_keys': {
'issue': [1],
},
}


class ConvertEndpointParamsTests(TestCase):
def test_simple(self):
Expand Down