Skip to content

ref: Move pagination styles into component #13560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2019
Merged

ref: Move pagination styles into component #13560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/sentry/static/sentry/app/components/pagination.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
import PropTypes from 'prop-types';
import React from 'react';
import {browserHistory} from 'react-router';
import {css} from 'react-emotion';

import utils from 'app/utils';
import {t} from 'app/locale';

const streamCss = css`
margin: 20px 0 0 0;

.icon-arrow-right,
.icon-arrow-left {
font-size: 20px !important;
}
`;

export default class Pagination extends React.Component {
static propTypes = {
pageLinks: PropTypes.string,
Expand All @@ -25,7 +35,7 @@ export default class Pagination extends React.Component {
query,
});
},
className: 'stream-pagination',
className: streamCss,
};

render() {
Expand Down
14 changes: 0 additions & 14 deletions src/sentry/static/sentry/less/stream.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,20 +995,6 @@
}
}

/**
* Stream Pagination
* ============================================================================
*/

.stream-pagination {
margin: 20px 0 0 0;

.icon-arrow-right,
.icon-arrow-left {
font-size: 20px !important;
}
}

/**
* Empty Stream/Empty Alert box
* ============================================================================
Expand Down
2 changes: 1 addition & 1 deletion tests/js/spec/views/__snapshots__/organizationTeamProjects.spec.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,7 @@ exports[`OrganizationTeamProjects Should render 1`] = `
</Panel>
<Pagination
api={Client {}}
className="stream-pagination"
className="css-1yt0wm7-streamCss"
location={
Object {
"query": Object {},
Expand Down
4 changes: 2 additions & 2 deletions tests/js/spec/views/__snapshots__/projectDebugFiles.spec.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ exports[`ProjectDebugFiles renders 1`] = `
</Component>
</Panel>
<Pagination
className="stream-pagination"
className="css-1yt0wm7-streamCss"
onCursor={[Function]}
/>
</ProjectDebugSymbols>
Expand Down Expand Up @@ -349,7 +349,7 @@ exports[`ProjectDebugFiles renders empty 1`] = `
</PanelBody>
</Panel>
<Pagination
className="stream-pagination"
className="css-1yt0wm7-streamCss"
onCursor={[Function]}
/>
</Fragment>
Expand Down
2 changes: 1 addition & 1 deletion tests/js/spec/views/groupDetails/__snapshots__/groupSimilar.spec.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1878,7 +1878,7 @@ exports[`Issues Similar View renders with mocked data 1`] = `
</div>
</div>
<Pagination
className="stream-pagination"
className="css-1yt0wm7-streamCss"
onCursor={[Function]}
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion tests/js/spec/views/groupDetails/__snapshots__/projectGroupEvents.spec.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ exports[`groupEvents renders 1`] = `
</PanelBody>
</Panel>
<Pagination
className="stream-pagination"
className="css-1yt0wm7-streamCss"
onCursor={[Function]}
/>
</div>
Expand Down