Skip to content

ref(ui): Remove Project User feedback #13503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions src/sentry/static/sentry/app/components/projectHeader/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,7 @@ class ProjectHeader extends React.Component {
const org = this.props.organization;
const allEnvironmentsLabel = t('All environments');

const pagesWithEnvironments = new Set([
'stream',
'releases',
'dashboard',
'events',
'user-feedback',
]);
const pagesWithEnvironments = new Set(['stream', 'releases', 'dashboard', 'events']);
const showEnvironmentsToggle = pagesWithEnvironments.has(navSection);

const activeEnvironmentTitle = activeEnvironment
Expand All @@ -71,11 +65,6 @@ class ProjectHeader extends React.Component {
{t('Overview')}
</ProjectLink>
</li>
<li className={navSection == 'user-feedback' ? 'active' : ''}>
<ProjectLink to={`/${org.slug}/${project.slug}/user-feedback/`}>
{t('User Feedback')}
</ProjectLink>
</li>
<li className={navSection == 'releases' ? 'active' : ''}>
<ProjectLink to={`/${org.slug}/${project.slug}/releases/`}>
{t('Releases')}
Expand Down
9 changes: 2 additions & 7 deletions src/sentry/static/sentry/app/routes.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -1242,13 +1242,8 @@ function routes() {
component={errorHandler(LazyLoad)}
/>
</Route>
<Route
path="user-feedback/"
componentPromise={() =>
import(/* webpackChunkName: "ProjectUserFeedback" */ './views/userFeedback/projectUserFeedback')
}
component={errorHandler(LazyLoad)}
/>

<Redirect from="user-feedback/" to="/organizations/:orgId/user-feedback/" />

<Route path="settings/" component={errorHandler(ProjectSettings)}>
<Redirect from="teams/" to="/settings/:orgId/projects/:projectId/teams/" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,10 @@ import styled from 'react-emotion';

import {PageContent} from 'app/styles/organization';
import {t} from 'app/locale';
import Alert from 'app/components/alert';
import AsyncView from 'app/views/asyncView';
import CompactIssue from 'app/components/compactIssue';
import EmptyStateWarning from 'app/components/emptyStateWarning';
import EventUserFeedback from 'app/components/events/userFeedback';
import Feature from 'app/components/acl/feature';
import GlobalSelectionHeader from 'app/components/organizations/globalSelectionHeader';
import LoadingIndicator from 'app/components/loadingIndicator';
import NoProjectMessage from 'app/components/noProjectMessage';
Expand Down Expand Up @@ -75,14 +73,6 @@ class OrganizationUserFeedback extends AsyncView {
);
}

renderNoAccess() {
return (
<PageContent>
<Alert type="warning">{t("You don't have access to this feature")}</Alert>
</PageContent>
);
}

renderLoading() {
return this.renderBody();
}
Expand All @@ -108,11 +98,7 @@ class OrganizationUserFeedback extends AsyncView {
const {reportListPageLinks} = this.state;

return (
<Feature
features={['organizations:sentry10']}
organization={organization}
renderDisabled={this.renderNoAccess}
>
<React.Fragment>
<GlobalSelectionHeader organization={organization} />
<PageContent>
<NoProjectMessage organization={organization}>
Expand All @@ -125,7 +111,7 @@ class OrganizationUserFeedback extends AsyncView {
</UserFeedbackContainer>
</NoProjectMessage>
</PageContent>
</Feature>
</React.Fragment>
);
}
}
Expand Down

This file was deleted.

Loading