Skip to content

ref(native): Remove the legacy stacktrace processor #13500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 1 addition & 88 deletions src/sentry/lang/native/minidump.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,9 @@
import dateutil.parser as dp
from msgpack import unpack, Unpacker, UnpackException, ExtraData

from sentry.event_manager import validate_and_set_timestamp
from sentry.lang.native.utils import get_sdk_from_event, merge_symbolicated_frame
from sentry.lang.native.symbolicator import merge_symbolicator_image
from sentry.lang.native.error import SymbolicationFailed, write_error
from sentry.models.eventerror import EventError
from sentry.attachments import attachment_cache
from sentry.coreapi import cache_key_for_event
from sentry.utils.safe import get_path, set_path, setdefault_path
from sentry.utils.safe import setdefault_path

minidumps_logger = logging.getLogger('sentry.minidumps')

Expand All @@ -23,11 +18,6 @@
MAX_MSGPACK_EVENT_SIZE_BYTES = 100000


def is_minidump_event(data):
exceptions = get_path(data, 'exception', 'values', filter=True)
return get_path(exceptions, 0, 'mechanism', 'type') in ('minidump', 'unreal')


def write_minidump_placeholder(data):
# Minidump events must be native platform.
data['platform'] = 'native'
Expand Down Expand Up @@ -113,80 +103,3 @@ def get_attached_minidump(data):
cache_key = cache_key_for_event(data)
attachments = attachment_cache.get(cache_key) or []
return next((a for a in attachments if a.type == MINIDUMP_ATTACHMENT_TYPE), None)


def merge_symbolicator_minidump_system_info(data, system_info):
set_path(data, 'contexts', 'os', 'type', value='os') # Required by "get_sdk_from_event"
setdefault_path(data, 'contexts', 'os', 'name', value=system_info.get('os_name'))
setdefault_path(data, 'contexts', 'os', 'version', value=system_info.get('os_version'))
setdefault_path(data, 'contexts', 'os', 'build', value=system_info.get('os_build'))

set_path(data, 'contexts', 'device', 'type', value='device')
setdefault_path(data, 'contexts', 'device', 'arch', value=system_info.get('cpu_arch'))


def merge_symbolicator_minidump_response(data, response):
data['platform'] = 'native'
if response.get('crashed') is not None:
data['level'] = 'fatal' if response['crashed'] else 'info'

validate_and_set_timestamp(data, response.get('timestamp'))

if response.get('system_info'):
merge_symbolicator_minidump_system_info(data, response['system_info'])

sdk_info = get_sdk_from_event(data)

images = []
set_path(data, 'debug_meta', 'images', value=images)

for complete_image in response['modules']:
image = {}
merge_symbolicator_image(
image, complete_image, sdk_info,
lambda e: write_error(e, data)
)
images.append(image)

# Extract the crash reason and infos
data_exception = get_path(data, 'exception', 'values', 0)
exc_value = (
'Assertion Error: %s' % response.get('assertion')
if response.get('assertion')
else 'Fatal Error: %s' % response.get('crash_reason')
)
data_exception['value'] = exc_value
data_exception['type'] = response.get('crash_reason')

data_threads = []
if response['stacktraces']:
data['threads'] = {'values': data_threads}
else:
error = SymbolicationFailed(message='minidump has no thread list',
type=EventError.NATIVE_SYMBOLICATOR_FAILED)
write_error(error, data)

for complete_stacktrace in response['stacktraces']:
is_requesting = complete_stacktrace.get('is_requesting')
thread_id = complete_stacktrace.get('thread_id')

data_thread = {
'id': thread_id,
'crashed': is_requesting,
}
data_threads.append(data_thread)

if is_requesting:
data_exception['thread_id'] = thread_id
data_stacktrace = data_exception.setdefault('stacktrace', {})
data_stacktrace['frames'] = []
else:
data_thread['stacktrace'] = data_stacktrace = {'frames': []}

if complete_stacktrace.get('registers'):
data_stacktrace['registers'] = complete_stacktrace['registers']

for complete_frame in reversed(complete_stacktrace['frames']):
new_frame = {}
merge_symbolicated_frame(new_frame, complete_frame)
data_stacktrace['frames'].append(new_frame)
Loading