Skip to content

ref(minidump): Remove setting to cache minidump uploads #13491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2019
Merged

ref(minidump): Remove setting to cache minidump uploads #13491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0fbb32f
ref(minidump): Deprecate setting to cache minidump uploads
jan-auer Jun 3, 2019
562ea46
ref(settings): Remove deprecated setting
jan-auer Jun 3, 2019
986d374
Merge branch 'master' into ref/remove-minidump-cache
jan-auer Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/sentry/conf/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1566,11 +1566,6 @@ def get_sentry_sdk_config():
TERMS_URL = None
PRIVACY_URL = None

# Toggles whether minidumps should be cached
SENTRY_MINIDUMP_CACHE = False
# The location for cached minidumps
SENTRY_MINIDUMP_PATH = '/tmp/minidump'

# Internal sources for debug information files
SENTRY_BUILTIN_SOURCES = {
'microsoft': {
Expand Down
9 changes: 0 additions & 9 deletions src/sentry/web/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

import jsonschema
import logging
import os
import random
import six
import traceback
Expand Down Expand Up @@ -762,14 +761,6 @@ def post(self, request, project, **kwargs):
"empty_minidump")
raise APIError('Empty minidump upload received')

if settings.SENTRY_MINIDUMP_CACHE:
if not os.path.exists(settings.SENTRY_MINIDUMP_PATH):
os.mkdir(settings.SENTRY_MINIDUMP_PATH, 0o744)

with open('%s/%s.dmp' % (settings.SENTRY_MINIDUMP_PATH, event_id), 'wb') as out:
for chunk in minidump.chunks():
out.write(chunk)

# Always store the minidump in attachments so we can access it during
# processing, regardless of the event-attachments feature. This will
# allow us to stack walk again with CFI once symbols are loaded.
Expand Down