Skip to content

feat(event-search): Organization Event Json endpoint #13459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/sentry/api/endpoints/project_event_details.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
from __future__ import absolute_import

import json

from datetime import datetime
from rest_framework.response import Response

from sentry import options
Expand Down Expand Up @@ -79,3 +82,18 @@ def get_legacy(self, request, project, event_id):
data['previousEventID'] = prev_event_id

return Response(data)


class EventJsonEndpoint(ProjectEndpoint):

def get(self, request, project, event_id):
event = SnubaEvent.objects.from_event_id(event_id, project.id)

if not event:
return Response({'detail': 'Event not found'}, status=404)

event_dict = event.as_dict()
if isinstance(event_dict['datetime'], datetime):
event_dict['datetime'] = event_dict['datetime'].isoformat()

return Response(json.dumps(event_dict), status=200)
7 changes: 6 additions & 1 deletion src/sentry/api/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@
from .endpoints.project_environment_details import ProjectEnvironmentDetailsEndpoint
from .endpoints.project_platforms import ProjectPlatformsEndpoint
from .endpoints.project_events import ProjectEventsEndpoint
from .endpoints.project_event_details import ProjectEventDetailsEndpoint
from .endpoints.project_event_details import ProjectEventDetailsEndpoint, EventJsonEndpoint
from .endpoints.project_filters import ProjectFiltersEndpoint
from .endpoints.project_filter_details import ProjectFilterDetailsEndpoint
from .endpoints.project_group_index import ProjectGroupIndexEndpoint
Expand Down Expand Up @@ -953,6 +953,11 @@
EventFileCommittersEndpoint.as_view(),
name='sentry-api-0-event-file-committers'
),
url(
r'^projects/(?P<organization_slug>[^\/]+)/(?P<project_slug>[^\/]+)/events/(?P<event_id>[\w-]+)/json/$',
EventJsonEndpoint.as_view(),
name='sentry-api-0-event-json'
),
url(
r'^projects/(?P<organization_slug>[^\/]+)/(?P<project_slug>[^\/]+)/events/(?P<event_id>[\w-]+)/owners/$',
EventOwnersEndpoint.as_view(),
Expand Down
76 changes: 76 additions & 0 deletions tests/snuba/api/endpoints/test_project_event_details.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import absolute_import

import json
import six

from datetime import timedelta
Expand Down Expand Up @@ -125,3 +126,78 @@ def test_snuba_with_environment(self):
assert response.data['previousEventID'] is None
assert response.data['nextEventID'] == self.next_event.event_id
assert response.data['groupID'] == six.text_type(self.prev_event.group.id)


class ProjectEventJsonEndpointTest(APITestCase, SnubaTestCase):
def setUp(self):
super(ProjectEventJsonEndpointTest, self).setUp()
self.login_as(user=self.user)
self.event_id = 'c' * 32
self.fingerprint = ['group_2']
self.min_ago = (timezone.now() - timedelta(minutes=1)).isoformat()[:19]
self.event = self.store_event(
data={
'event_id': self.event_id,
'timestamp': self.min_ago,
'fingerprint': self.fingerprint,
'user': {
'email': self.user.email,
},
},
project_id=self.project.id,
)
self.url = reverse(
'sentry-api-0-event-json',
kwargs={
'organization_slug': self.organization.slug,
'project_slug': self.project.slug,
'event_id': self.event_id,
}
)

def assert_event(self, data):
data = json.loads(data.decode('utf-8'))
assert data['event_id'] == self.event_id
assert data['user']['email'] == self.user.email
assert data['datetime'][:19] == self.min_ago
assert data['fingerprint'] == self.fingerprint

def test_simple(self):
response = self.client.get(self.url, format='json')
assert response.status_code == 200, response.content
self.assert_event(response.data)

def test_event_does_not_exist(self):
self.url = reverse(
'sentry-api-0-event-json',
kwargs={
'organization_slug': self.organization.slug,
'project_slug': self.project.slug,
'event_id': 'no' * 16,
}
)
response = self.client.get(self.url, format='json')
assert response.status_code == 404, response.content
assert response.data == {'detail': 'Event not found'}

def test_user_unauthorized(self):
user = self.create_user()
self.login_as(user)

response = self.client.get(self.url, format='json')
assert response.status_code == 403, response.content
assert response.data == {'detail': 'You do not have permission to perform this action.'}

def test_project_not_associated_with_event(self):
project2 = self.create_project(organization=self.organization)
url = reverse(
'sentry-api-0-event-json',
kwargs={
'organization_slug': self.organization.slug,
'project_slug': project2.slug,
'event_id': self.event_id,
}
)
response = self.client.get(url, format='json')
assert response.status_code == 404, response.content
assert response.data == {'detail': 'Event not found'}