-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(events-v2) Add rough sketch of event modal #13415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b444fec
feat(events-v2) Add rough sketch of event modal
markstory 0fa62f7
Use an errorboundary around event interface rendering
markstory b8ef95c
Add basic tags table and preserve query string when going into a modal
markstory 43f3c93
Add basic integration tests for new modal
markstory 1fc591e
Improve padding and make title match mockup.
markstory 6a747ea
Refine styling more.
markstory File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
import {isNativePlatform} from 'app/utils/platform'; | ||
|
||
/** | ||
* Extract the display message from an event. | ||
*/ | ||
export function getMessage(event) { | ||
const {metadata, type, culprit} = event; | ||
|
||
switch (type) { | ||
case 'error': | ||
return metadata.value; | ||
case 'csp': | ||
return metadata.message; | ||
case 'expectct': | ||
case 'expectstaple': | ||
case 'hpkp': | ||
return ''; | ||
default: | ||
return culprit || ''; | ||
} | ||
} | ||
|
||
/** | ||
* Get the location from an event. | ||
*/ | ||
export function getLocation(event) { | ||
if (event.type === 'error' && isNativePlatform(event.platform)) { | ||
const {metadata} = event || {}; | ||
return metadata.filename || null; | ||
} | ||
return null; | ||
} | ||
|
||
export function getTitle(event) { | ||
const {metadata, type, culprit} = event; | ||
let {title} = event; | ||
let subtitle = null; | ||
|
||
if (type == 'error') { | ||
subtitle = culprit; | ||
if (metadata.type) { | ||
title = metadata.type; | ||
} else { | ||
title = metadata.function || '<unknown>'; | ||
} | ||
} else if (type == 'csp') { | ||
title = metadata.directive; | ||
subtitle = metadata.uri; | ||
} else if (type === 'expectct' || type === 'expectstaple' || type === 'hpkp') { | ||
title = metadata.message; | ||
subtitle = metadata.origin; | ||
} else if (type == 'default') { | ||
title = metadata.title; | ||
} | ||
|
||
return {title, subtitle}; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of making our own query string, we could pass
to
an object withpathname
andquery
keys.