Skip to content

fix(tracemetrics): Styling on visualize field for alerts#113704

Merged
narsaynorath merged 2 commits into
masterfrom
nar/fix/tracemetrics-equation-visualize-styling-on-alerts
Apr 22, 2026
Merged

fix(tracemetrics): Styling on visualize field for alerts#113704
narsaynorath merged 2 commits into
masterfrom
nar/fix/tracemetrics-equation-visualize-styling-on-alerts

Conversation

@narsaynorath

Copy link
Copy Markdown
Member
  • disables the metric selector if there aren't any options
  • stretches the field the entire row
  • prevents long metric names from overflowing
description before after
stretches the entire row Screenshot 2026-04-22 at 1 42 50 PM Screenshot 2026-04-22 at 1 44 16 PM
prevents long metric names from overflowing Screenshot 2026-04-22 at 1 45 31 PM Screenshot 2026-04-22 at 1 45 54 PM

@narsaynorath
narsaynorath requested a review from a team April 22, 2026 17:46
@narsaynorath
narsaynorath requested a review from a team as a code owner April 22, 2026 17:46
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 22, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 32ac698. Configure here.

Comment thread static/app/views/explore/metrics/metricToolbar/metricSelector.tsx Outdated
Comment thread static/app/views/explore/metrics/metricToolbar/metricSelector.tsx Outdated
Reverting to decide if this is actually what we want. There's a test that tests
a different pattern
@narsaynorath
narsaynorath merged commit 8e0b76b into master Apr 22, 2026
65 checks passed
@narsaynorath
narsaynorath deleted the nar/fix/tracemetrics-equation-visualize-styling-on-alerts branch April 22, 2026 18:12
@github-actions github-actions Bot locked and limited conversation to collaborators May 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants