fix(page-frame): remove empty headers and move breadcrumbs#113654
Merged
Conversation
Pages whose Layout.Title and actions all teleport to TopBar.Slot in page-frame mode render an empty <header><div/></header> band at the top of the page. Add an explicit top-level split in each affected header component: when page-frame is active, return the TopBar.Slot content directly without wrapping in Layout.Header. Covers: explore/logs, explore/errors, explore/metrics, explore/savedQueries. Co-Authored-By: Claude <noreply@anthropic.com>
In page-frame mode, legacy inline <Breadcrumbs> inside Layout.HeaderContent left a visible per-page header even though Title and actions had already teleported to the top bar. Move the breadcrumb content into <TopBar.Slot name="title"> (matching dashboards/detail) so it appears alongside the title in the top bar. Covers: explore/multiQueryMode, discover/landing, projectDetail. The projectDetail case keeps Layout.Header around because the three action buttons next to Feedback do not teleport. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Removing Layout.HeaderContent in page-frame mode left Layout.Header with only one grid child, which placed HeaderActions in the 1fr column — stretching the three action buttons full width. Keep HeaderContent in the grid (with the TopBar.Slot inside) so actions fall back into the auto column and right-align as before. Also shrink the project IdBadge in the breadcrumb last crumb from 20 to 16 and wrap it with the slug in a centered Flex so the icon and text line up. Co-Authored-By: Claude <noreply@anthropic.com>
priscilawebdev
commented
Apr 22, 2026
| /> | ||
| </Layout.HeaderContent> | ||
| {hasPageFrameFeature ? ( | ||
| {hasPageFrameFeature ? ( |
|
|
||
| const hasBreadcrumb = Boolean(title && defined(pageId)); | ||
|
|
||
| if (hasPageFrameFeature) { |
|
|
||
| const hasBreadcrumb = Boolean(title && defined(pageId)); | ||
|
|
||
| if (hasPageFrameFeature) { |
| </TopBar.Slot> | ||
| </Fragment> | ||
| ) : ( | ||
| {hasPageFrameFeature ? ( |
| )} | ||
| /> | ||
| ) : ( | ||
| <LinkButton |
| disableLink | ||
| hideName | ||
| {hasPageFrameFeature ? ( | ||
| <TopBar.Slot name="title"> |
OrganizationLayout already wraps every route in Layout.Page (which renders as <main>), so the inner Layout.Page in explore/errors/content produced a second <main> inside the first. Drop the inner wrapper; the page body is now a direct child of SentryDocumentTitle, inheriting the outer <main> from OrganizationLayout. Co-Authored-By: Claude <noreply@anthropic.com>
In page-frame mode Layout.Title teleports and actions go to TopBar.Slot, leaving Layout.HeaderContent rendering as an empty <div> above the dataset tabs. Swap HeaderContent/HeaderActions for TopBar.Slot title/actions when page-frame is active so only the tabs remain as direct children of <Layout.Header>. DatasetSelectorTabs keep their header placement in both modes. Co-Authored-By: Claude <noreply@anthropic.com>
After extracting the title node into a const, the legacy-mode "discover-basic only" branch wrapped a single <Layout.Title> in a <Fragment>. Drop the wrapper. Co-Authored-By: Claude <noreply@anthropic.com>
Collapse the two inline hasPageFrameFeature checks into one top-level branch, and extract the shared breadcrumb + event-name block into a local so it is only written once. Layout.Header and DatasetSelectorTabs stay as common wrappers in both modes. Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5c928c7. Configure here.
TkDodo
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See screenshots.
contributes to https://linear.app/getsentry/issue/DE-1116/header-renders-as-an-empty-element