feat(explorer): updated drawer header with dropdown menu#113637
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
aliu39
changed the title
Zylphrex
left a comment
Zylphrex
left a comment
There was a problem hiding this comment.
A few questions but otherwise LGTM
There was a problem hiding this comment.
More of a general design question - Any reason why we chose to hide the close button text instead of keeping it consistent everywhere?
There was a problem hiding this comment.
Was matching the figma - personally I think it looks cleaner, but don't have a strong preference
| * Whether to close the menu when this item is clicked. Overrides the list-level | ||
| * `closeOnSelect` prop when set. | ||
| */ | ||
| closeOnSelect?: boolean; |
There was a problem hiding this comment.
Why is this override necessary when we can just set the closeOnSelect on the item?
There was a problem hiding this comment.
the item-level closeOnSelect wasn't available before, only an option for closeOnSelect on all items. For all items except history, we want to close on select
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7cd4921. Configure here.
3 participants
closeOnSelect=false(CE CM toggles are internal-only)
menu.mov