fix(tracemetrics): Pass project and env in alerts#113551
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8535fd0. Configure here.
| return [Number(projectId)]; | ||
| } | ||
| return []; | ||
| }, [projectId]); |
There was a problem hiding this comment.
Empty array prevents fallback to page filter projects
Medium Severity
When projectId is falsy, projectIds is set to [] instead of undefined. In useMetricOptions, the nullish coalescing operator (projectIds ?? selection.projects) won't fall back to page filter projects for an empty array, unlike environments which correctly returns undefined to trigger the fallback. This means metric options will be fetched without any project filter when the form's project field is empty, showing metrics from all projects instead of respecting page filters.
Reviewed by Cursor Bugbot for commit 8535fd0. Configure here.
There was a problem hiding this comment.
ack, will need to fix later, just trying to get this mostly working for bug bash
2 participants
No description provided.