fix(issue-views): Render editable title in topbar slot for page-frame layout#113488
Merged
Conversation
… layout When clicking to edit an issue view title with the page-frame feature enabled, the editing input rendered into the page body instead of the topbar slot, causing a visible layout shift. Add explicit page-frame path that wraps both editing and non-editing states in TopBar.Slot. Use PageFrameViewTitleWrapper (plain div) and PageFrameGrowingInput (without fixed 40px height/font overrides) so the topbar's default sizing applies. Legacy path is unchanged. Refs DE-1132 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
JonasBa
marked this pull request as ready for review
April 20, 2026 22:10
Member
|
I noticed that when editing a title now, it shifts a little: Screen.Recording.2026-04-21.at.09.15.26.mov |
Contributor
Author
Excellent eye @priscilawebdev! I've went ahead and removed the dashed border, I think that is excessive of an indicator given that we already render the button next to the title |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a5ea497. Configure here.
natemoo-re
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update editable title in page frame mode to render into the topbar slot when editing and reduce the size of the header to use the default size
Fixes DE-1132