Skip to content

fix(metrics): Prevent page scroll when opening metric selector#113460

Merged
nsdeschenes merged 1 commit into
masterfrom
nd/fix-tracemetrics-remove-scroll-on-focus
Apr 20, 2026
Merged

fix(metrics): Prevent page scroll when opening metric selector#113460
nsdeschenes merged 1 commit into
masterfrom
nd/fix-tracemetrics-remove-scroll-on-focus

Conversation

@nsdeschenes

@nsdeschenes nsdeschenes commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Introduce our own focus logic to prevent the page from scrolling when the trace metrics selector dropdown is opened.

The metric selector's search input used `autoFocus`, which triggered
the browser's default scroll-into-view behavior and caused the page
to jump when the dropdown opened. Focus the input manually with
`preventScroll: true` in the existing open handler instead.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 20, 2026
@nsdeschenes
nsdeschenes marked this pull request as ready for review April 20, 2026 18:16
@nsdeschenes
nsdeschenes requested a review from a team as a code owner April 20, 2026 18:16
@nsdeschenes
nsdeschenes merged commit de80d98 into master Apr 20, 2026
67 checks passed
@nsdeschenes
nsdeschenes deleted the nd/fix-tracemetrics-remove-scroll-on-focus branch April 20, 2026 18:40
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants