fix(trace): Keep loading breadcrumbs in the page-frame top bar#113384
Merged
Conversation
Render the trace header placeholder breadcrumbs through the page-frame title slot so the loading state matches the loaded header layout. Add a regression test that covers the pending trace header branch with page frame enabled to prevent the breadcrumbs from flashing inline before they portal into the top bar. Refs DE-1119 Co-Authored-By: OpenAI Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
JonasBa
marked this pull request as ready for review
April 18, 2026 19:30
TkDodo
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render the trace header placeholder breadcrumbs through the page-frame top bar while the trace metadata is still loading.
The loaded trace header already portals its breadcrumbs into the top bar in page-frame mode, but the placeholder kept rendering them inline in the page body first. That caused a brief layout flash before the breadcrumbs moved into the correct slot.
This updates the placeholder to use the same title slot and adds a focused regression test for the pending state under page frame.
Fixes DE-1119