fix(onboarding): Emit scm_platform_selected on auto-detection#113351
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Fire `onboarding.scm_platform_selected` with `source: 'detected'` once when platform auto-detection resolves and the user has not explicitly chosen a platform. Previously the event only fired when the user clicked on a detected card or picked manually, so users who accepted the recommended platform and advanced with Continue never emitted a platform-selected event and the funnel was missing a step. Refs VDY-90
jaydgoss
force-pushed
the
jaygoss/fix-scm-platform-selected-auto-detect
branch
from
April 17, 2026 20:28
5283692 to
c93621f
Compare
jaydgoss
marked this pull request as ready for review
April 17, 2026 20:40
evanpurkhiser
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fire
onboarding.scm_platform_selectedwithsource: 'detected'once when the SCM onboarding platform auto-detection resolves and the user has not explicitly chosen a platform.Previously the event only fired when the user clicked a detected platform card or picked manually. Users who accepted the recommended platform and advanced with Continue never emitted a platform-selected event, leaving the funnel without a step between
scm_platform_features_step_viewedandscm_platform_features_continue_clicked.The event is gated by a ref so it fires at most once per mount. A test asserts that exactly one
source: 'detected'event fires when detection resolves on mount with no explicit selection.Refs VDY-90