fix(monitors): Move edit breadcrumbs into the top bar#113272
Merged
priscilawebdev merged 11 commits intoApr 20, 2026
Conversation
Render existing monitor edit breadcrumbs through the TopBar title slot\nwhen the page-frame feature is enabled. This keeps the edit header\naligned with the newer page-frame layout without changing the legacy\nform header.\n\nCo-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Only render the error monitor edit title and project badge in the legacy\nheader path. In page-frame mode the breadcrumb already provides the\nheader title, so leaving EditLayout.Title in place appended the monitor\nname into the top bar and left the project badge behind on its own row.\n\nCo-Authored-By: Codex <noreply@openai.com>
Skip the legacy edit header for error monitor edit pages when the\npage-frame feature is enabled. The title and feedback button already\nrender through TopBar slots in that mode, so keeping EditLayout.Header\nin place left an empty row under the top bar.\n\nCo-Authored-By: Codex <noreply@openai.com>
Keep the project context visible on the error monitor edit page in\npage-frame mode by rendering the project badge alongside the breadcrumb\nin the top bar title area.\n\nCo-Authored-By: Codex <noreply@openai.com>
Align the error monitor edit page with the existing metric monitor\npage-frame layout by rendering the monitor name in the top bar title\nslot instead of keeping the project badge there.\n\nCo-Authored-By: Codex <noreply@openai.com>
Render the error monitor edit breadcrumb in page-frame mode as a\nsettings-style project path: Monitors / Error / <project> / Configure.\nThis keeps the project context visible without leaving a separate badge\nrow or mixing the project into the monitor title.\n\nCo-Authored-By: Codex <noreply@openai.com>
Use the same project-aware top bar breadcrumb on the error monitor detail and edit pages when page-frame is enabled. Keep the legacy header path unchanged so this stays scoped to the new top bar layout. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Make the project crumb in the error monitor edit breadcrumb navigate back to the detail view. Keep the detail breadcrumb itself as the current location. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Keep the error monitor detail and edit breadcrumbs local to their pages instead of sharing a helper. The detail and edit paths now own their slightly different breadcrumb behavior directly. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Inline the error monitor detail and edit breadcrumb markup where it is used instead of keeping small local wrapper components. This keeps the page-frame-only breadcrumb variants directly next to their slots. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Reuse the edit route's resolved project instead of looking it up again inside the error monitor edit components. This makes the project requirement explicit and removes the defensive breadcrumb guard from the page-frame edit header. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 843bcdc. Configure here.
priscilawebdev
commented
Apr 17, 2026
| return <EditExistingUptimeDetectorForm detector={detector} />; | ||
| case 'error': | ||
| return <EditExistingErrorDetectorForm detector={detector} />; | ||
| return <EditExistingErrorDetectorForm detector={detector} project={project} />; |
Member
Author
There was a problem hiding this comment.
I agree this is a little awkward since only this form uses project. The main reason I did it this way is that the route already guarantees a project, so passing it down lets us remove the defensive undefined checks from the form and keep the breadcrumb/rendering logic simpler. I don’t feel strongly about it though, and I’m happy to adjust if you’d prefer a different shape
TkDodo
approved these changes
Apr 20, 2026
priscilawebdev
deleted the
priscilawebdev/fix/monitor-edit-topbar-breadcrumbs
branch
April 20, 2026 08:08
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Screen.Recording.2026-04-17.at.11.55.18.mov
After
Screen.Recording.2026-04-17.at.11.55.45.mov
closes https://linear.app/getsentry/issue/DE-1141/monitors-doesnt-render-breadcrumbs-into-the-title-slot