fix(page-frame): Constrain replay and feedback layouts#113266
Merged
priscilawebdev merged 8 commits intoApr 20, 2026
Conversation
github-actions
Bot
added
the
Scope: Frontend
priscilawebdev
changed the title
priscilawebdev
force-pushed
the
priscilawebdev/fix/replay-page-frame-viewport-sizing
branch
from
April 17, 2026 12:58
9c2fbb3 to
4152424
Compare
priscilawebdev
marked this pull request as ready for review
April 17, 2026 13:09
natemoo-re
approved these changes
Apr 17, 2026
natemoo-re
left a comment
natemoo-re
left a comment
Member
There was a problem hiding this comment.
A few suggestions but looks good overall—feel free to address prior to merge.
Comment on lines
+174
to
+208
| const pageBody = ( | ||
| <PageFiltersContainer> | ||
| <ErrorBoundary> | ||
| <Stack flex={1} align="stretch" gap="xl" background="primary" overflow="hidden"> | ||
| <LayoutGrid hideTop={hideTop}> | ||
| {!hideTop && ( | ||
| <Stack | ||
| flexGrow={1} | ||
| gap="md" | ||
| area="top" | ||
| direction={{xs: 'column', sm: 'row'}} | ||
| align={{xs: 'stretch', sm: 'start'}} | ||
| > | ||
| <FeedbackFilters /> | ||
| <SearchContainer> | ||
| <FeedbackSearch /> | ||
| </SearchContainer> | ||
| </Stack> | ||
| )} | ||
| {hasSetupOneFeedback || hasSlug ? ( | ||
| isMediumOrSmaller ? ( | ||
| smallerScreenView | ||
| ) : ( | ||
| largeScreenView | ||
| ) | ||
| ) : ( | ||
| <SetupContainer> | ||
| <FeedbackSetupPanel /> | ||
| </SetupContainer> | ||
| )} | ||
| </LayoutGrid> | ||
| </Stack> | ||
| </ErrorBoundary> | ||
| </PageFiltersContainer> | ||
| ); |
Member
There was a problem hiding this comment.
A local variable is a good sign this could be extracted to a local <PageContent /> component
Comment on lines
+315
to
+317
| const PageFrameViewport = styled(Stack)` | ||
| contain: size; | ||
| `; |
Member
There was a problem hiding this comment.
Let's add a contain prop to Container so all our layout components can set this?
billyvg
reviewed
Apr 17, 2026
billyvg
left a comment
billyvg
left a comment
Member
There was a problem hiding this comment.
I'll defer to nate on the CR, but visually looks good to me, thanks for fixing!
priscilawebdev
enabled auto-merge (squash)
April 20, 2026 06:34
priscilawebdev
deleted the
priscilawebdev/fix/replay-page-frame-viewport-sizing
branch
April 20, 2026 08:17
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/DE-1165/replay-detail-and-feedback-do-not-stretch-to-available-page-frame
Before
Screen.Recording.2026-04-17.at.14.58.55.mov
After
Screen.Recording.2026-04-17.at.15.01.01.mov