Skip to content

ref(pipeline): Extract shared test helpers from pipeline integration specs#113224

Merged
evanpurkhiser merged 1 commit into
masterfrom
evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs
Apr 17, 2026
Merged

ref(pipeline): Extract shared test helpers from pipeline integration specs#113224
evanpurkhiser merged 1 commit into
masterfrom
evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs

Conversation

@evanpurkhiser

Copy link
Copy Markdown
Member

Move duplicated makeStepProps factory, mock popup setup, and
dispatchPipelineMessage helper into a shared testUtils module.
createMakeStepProps captures pipeline-specific defaults (like
totalSteps) once per file, keeping individual test calls clean.

@evanpurkhiser
evanpurkhiser requested a review from a team as a code owner April 16, 2026 20:06
@evanpurkhiser
evanpurkhiser requested a review from a team April 16, 2026 20:06
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 16, 2026

@leeandher leeandher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@evanpurkhiser
evanpurkhiser force-pushed the evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs branch from d7f6505 to 3f1fa08 Compare April 16, 2026 20:59
@evanpurkhiser
evanpurkhiser enabled auto-merge (squash) April 16, 2026 20:59
@evanpurkhiser
evanpurkhiser force-pushed the evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs branch from 3f1fa08 to 70e0785 Compare April 16, 2026 22:30
@evanpurkhiser
evanpurkhiser force-pushed the evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs branch from 70e0785 to 859669f Compare April 17, 2026 14:46
@evanpurkhiser
evanpurkhiser force-pushed the evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs branch from 859669f to 141d8e5 Compare April 17, 2026 15:43
@evanpurkhiser
evanpurkhiser force-pushed the evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs branch from 141d8e5 to c1bc8ba Compare April 17, 2026 15:52
@evanpurkhiser
evanpurkhiser requested review from a team as code owners April 17, 2026 15:52
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@evanpurkhiser
evanpurkhiser force-pushed the evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs branch from c1bc8ba to d5e73b1 Compare April 17, 2026 15:53
@evanpurkhiser
evanpurkhiser force-pushed the evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs branch from d5e73b1 to 19166bf Compare April 17, 2026 16:03
…specs

Move duplicated makeStepProps factory, mock popup setup, and
dispatchPipelineMessage helper into a shared testUtils module.
createMakeStepProps captures pipeline-specific defaults (like
totalSteps) once per file, keeping individual test calls clean.
@evanpurkhiser
evanpurkhiser force-pushed the evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs branch from 19166bf to f8e1aa5 Compare April 17, 2026 16:06
@evanpurkhiser
evanpurkhiser merged commit e21c1b9 into master Apr 17, 2026
65 checks passed
@evanpurkhiser
evanpurkhiser deleted the evanpurkhiser/ref-pipeline-extract-shared-test-helpers-from-pipeline-integration-specs branch April 17, 2026 16:13
@github-actions github-actions Bot locked and limited conversation to collaborators May 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants