feat(logs): switch needle-in-haystack auto-fetching from 5 tries to time-based#113219
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 654f9d4. Configure here.
| 'explore.logs.flex_time_pages_before_data', | ||
| timesFetched.current, | ||
| {attributes: {status: 'fetching'}} | ||
| ); |
There was a problem hiding this comment.
@k-fish do you have advice on what to do for these metrics logs? I'm thinking the out-of-time vs. fetching one matches the original PR's intent, roughly?
There was a problem hiding this comment.
I think it'll be fine, it'll fire once for each page as fetching then one out_of_time at the end?
k-fish
left a comment
k-fish
left a comment
There was a problem hiding this comment.
Looks good, were you planning on looking into the loading state making the rows unclickable in a future PR?
| 'explore.logs.flex_time_pages_before_data', | ||
| timesFetched.current, | ||
| {attributes: {status: 'fetching'}} | ||
| ); |
There was a problem hiding this comment.
I think it'll be fine, it'll fire once for each page as fetching then one out_of_time at the end?
JoshuaKGoldberg
changed the title
2 participants
Continues #102286 -> #111946 by:
useAutoFetchWindowhookFixes LOGS-708.