ref(tracemetrics): Extract state keeping from state changes in provider#113211
Merged
narsaynorath merged 1 commit intoApr 20, 2026
Conversation
This generalizes the state changes so I can change the way we store state from flushing to the URL to keeping local state. This will be necessary for Alerts where Alerts should only store the final equation. I only need to parse the equation and locally render the subcomponents.
github-actions
Bot
added
the
Scope: Frontend
narsaynorath
deleted the
nar/ref/tracemetrics-equations-extract-state-keeping-from-state-changes
branch
April 20, 2026 13:41
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts how the state changes from what the state changes are. On Explore we persist it to the URL (i.e. with
navigate) and that gets re-read on re-render. In Alerts we'll need to use local state so separate the logic into helpers where thesetQueriespart can be configured by a parent component.Also pushes up
hasEquationsto the context so we can configure a different flag based on the rendering context (i.e. the alerts page will use a different flag)