ref(tsc): open-period endpoint to apiOptions#113167
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
TkDodo
commented
Apr 16, 2026
Comment on lines
+66
to
+70
| return useQuery({ | ||
| ...openPeriodsApiOptions({organization, limit: 1, ...params}), | ||
| enabled: defined(params.eventId) && defined(params.groupId), | ||
| select: ({json}) => json?.[0] ?? null, | ||
| }); |
Collaborator
Author
There was a problem hiding this comment.
I think this is beautiful and actually readable compared to before. It also fixes a (hidden) lint violation because spreading a query result ...query de-opts tracked queries!
TkDodo
marked this pull request as ready for review
April 16, 2026 14:38
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.