Skip to content

ref(tsc): replays endpoint to apiOptions#113158

Merged
TkDodo merged 5 commits into
masterfrom
tkdodo/ref/replays-endpoint-to-apiOptions
Apr 20, 2026
Merged

ref(tsc): replays endpoint to apiOptions#113158
TkDodo merged 5 commits into
masterfrom
tkdodo/ref/replays-endpoint-to-apiOptions

Conversation

@TkDodo

@TkDodo TkDodo commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 16, 2026
}

/** @internal exported for stories */
export function replayListInfiniteApiOptions(props: Props) {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to see that the whole infinite query stuff here is just for stories. There is no infinite query for replays in the product 🤯.

Shouldn’t stories (like tests) reflect what we’re actually using? The whole abstraction I created is kinda pointless, I only found out because knip:prod told me :/

@TkDodo
TkDodo marked this pull request as ready for review April 16, 2026 12:37
@TkDodo
TkDodo requested a review from a team as a code owner April 16, 2026 12:37

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5bf2727. Configure here.

Comment thread static/app/components/replays/table/replayTable.tsx
@TkDodo
TkDodo requested a review from a team April 16, 2026 13:24
# Conflicts:
#	static/app/views/replays/list/replayIndexContainer.tsx
#	static/app/views/replays/list/replayIndexTable.tsx
@TkDodo
TkDodo merged commit fa4855b into master Apr 20, 2026
65 checks passed
@TkDodo
TkDodo deleted the tkdodo/ref/replays-endpoint-to-apiOptions branch April 20, 2026 07:04
@github-actions github-actions Bot locked and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants