Flaky test other exception #107911
Draft
Flaky test other exception #107911
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_other_exception test was flaky because the SEER_ERROR_COUNT_KEY cache was not being cleared between tests. This caused tests to interfere with each other when run in different orders or in parallel. Added setUp() methods to both TestGetEventSeverity and TestEventManagerSeverity classes to clear the cache before each test, ensuring proper test isolation. Fixes ID-1347 Co-authored-by: Charlie Luo <cvxluo@gmail.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flakiness in
test_other_exceptionand related tests (ID-1347) by ensuring proper test isolation. TheSEER_ERROR_COUNT_KEYcache is now cleared insetUpmethods forTestGetEventSeverityandTestEventManagerSeverityto prevent state leakage between test runs.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Linear Issue: ID-1347