Issues pagination consistency #107903
Draft
Issues pagination consistency #107903
+129
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjust X-Hits proportionally when post-filtering removes results - Cap X-Hits to actual count when first page is short (fewer than requested limit) - Apply consistent fix to both organization and project group index endpoints - Add tests to verify X-Hits adjustment behavior Co-authored-by: Charlie Luo <cvxluo@gmail.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
github-actions
bot
added
the
Scope: Backend
- Break long lines to comply with line length limits - Improve comment readability Co-authored-by: Charlie Luo <cvxluo@gmail.com>
The test was expecting X-Hits to remain at the mocked value (100) even when only 10 results exist. This is incorrect - when we're on the first page with no more results, X-Hits should be capped to the actual count (10) to prevent showing incorrect totals like '1-10 of 100' when only 10 items exist. Co-authored-by: Charlie Luo <cvxluo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pagination inconsistencies in the Issues list by ensuring accurate
X-Hitsand consistent page item counts.Why these changes?
The Issues list pagination experienced:
X-Hits: The total count (X-Hitsheader) would fluctuate between pages due to sampling-based estimations and post-filtering.This resulted in incorrect "X–Y of Z" displays and a poor user experience.
What was changed?
X-Hitsfor post-filtering:X-Hitsis now proportionally adjusted downwards if post-filters remove items from the result set.X-Hitson short first pages: If the first page returns fewer items than requested (and no more results exist or the backend couldn't fill the page),X-Hitsis capped to the actual number of items returned.X-Hitsadjustment and capping behavior.These changes ensure
X-Hitsremains consistent and accurately reflects the total number of items after all filtering, resolving the pagination display issues.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Linear Issue: ID-1343