Test_same_group flakiness #107902
Draft
Test_same_group flakiness #107902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IssueTest The test was failing intermittently because new_issues_count is incremented via buffer_incr() in event_manager.py, but the test was reading directly from the database before the buffer was flushed. This change ensures the buffer is processed before assertions, resolving the flakiness. Fixes ID-1342 Co-authored-by: Charlie Luo <cvxluo@gmail.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flakiness in
tests/sentry/event_manager/test_event_manager.py::ReleaseIssueTest::test_same_group.The test was flaky because
new_issues_countis incremented via a buffer, but the test asserted the value directly from the database before the buffer was flushed. This PR adds a call tobuffer.backend.process()inassert_release_project_environmentto ensure the buffered value is flushed before the assertion.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Linear Issue: ID-1342