Same group test flakiness #107900
Draft
Same group test flakiness #107900
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvironment The test had a redundant re-assertion of event1 after creating event2, which was inconsistent with other tests in the ReleaseIssueTest class and prone to database transaction timing issues. Since event2 is created in a different environment (environment2), it should not affect event1's ReleaseProjectEnvironment (environment1). The redundant assertion was likely catching race conditions where database queries executed before transactions were fully committed. This fix makes the test consistent with test_different_groups and test_same_group, which only assert each event once. Fixes: ID-1341 Co-authored-by: Charlie Luo <cvxluo@gmail.com>
Contributor
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the flaky test
test_same_group_different_environment.The flakiness was caused by a redundant re-assertion of
event1afterevent2was created. This assertion was inconsistent with other tests in theReleaseIssueTestclass and introduced a potential race condition due to database transaction timing issues when querying immediately afterevent2's creation.Removing this unnecessary re-assertion resolves the flakiness and aligns the test with the established pattern in the test suite.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Linear Issue: ID-1341