Skip to content

Conversation

@wedamija
Copy link
Member

Final migration to fully delete the column

@wedamija wedamija requested a review from a team February 10, 2026 00:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 10, 2026
Final migration to fully delete the column
@wedamija wedamija force-pushed the danf/aci-delete-event-id branch from 4f27aeb to 7378d95 Compare February 10, 2026 00:05
@wedamija wedamija requested a review from a team as a code owner February 10, 2026 00:05
replays: 0007_organizationmember_replay_access

sentry: 1026_remove_group_open_period_event_id
sentry: 1027_delete_group_open_period_event_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The migrations_lockfile.txt references migration 1027_delete_group_open_period_event_id, but the corresponding migration file is missing from the repository, which will cause the CI check to fail.
Severity: CRITICAL

Suggested Fix

Add the missing migration file for 1027_delete_group_open_period_event_id. This file should contain the DeletionAction.DELETE operation, which is the second step of the SafeRemoveField pattern initiated in the preceding migration.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: migrations_lockfile.txt#L34

Potential issue: The `migrations_lockfile.txt` has been updated to reference migration
`1027_delete_group_open_period_event_id`, but the corresponding migration file is not
present in the repository. The CI workflow runs a script that validates the lockfile
against the actual migration files on disk using `sentry django makemigrations --check`.
This check will fail because the referenced migration file does not exist, which will
block the pull request from being merged and prevent deployment.

Did we get this right? 👍 / 👎 to inform future reviews.

@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/1026_remove_group_open_period_event_id.py src/sentry/migrations/1027_delete_group_open_period_event_id.py

for 1026_remove_group_open_period_event_id in sentry

--
-- Moved groupopenperiod.event_id field to pending deletion state
--
-- (no-op)

for 1027_delete_group_open_period_event_id in sentry

--
-- Remove field event_id from groupopenperiod
--
ALTER TABLE "sentry_groupopenperiod" DROP COLUMN "event_id" CASCADE;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants