-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore(open-periods): Delete GroupOpenPeriod.event_id
#107898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: danf/aci-remove-event-id
Are you sure you want to change the base?
Conversation
Final migration to fully delete the column
4f27aeb to
7378d95
Compare
| replays: 0007_organizationmember_replay_access | ||
|
|
||
| sentry: 1026_remove_group_open_period_event_id | ||
| sentry: 1027_delete_group_open_period_event_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The migrations_lockfile.txt references migration 1027_delete_group_open_period_event_id, but the corresponding migration file is missing from the repository, which will cause the CI check to fail.
Severity: CRITICAL
Suggested Fix
Add the missing migration file for 1027_delete_group_open_period_event_id. This file should contain the DeletionAction.DELETE operation, which is the second step of the SafeRemoveField pattern initiated in the preceding migration.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: migrations_lockfile.txt#L34
Potential issue: The `migrations_lockfile.txt` has been updated to reference migration
`1027_delete_group_open_period_event_id`, but the corresponding migration file is not
present in the repository. The CI workflow runs a script that validates the lockfile
against the actual migration files on disk using `sentry django makemigrations --check`.
This check will fail because the referenced migration file does not exist, which will
block the pull request from being merged and prevent deployment.
Did we get this right? 👍 / 👎 to inform future reviews.
|
This PR has a migration; here is the generated SQL for for --
-- Moved groupopenperiod.event_id field to pending deletion state
--
-- (no-op)for --
-- Remove field event_id from groupopenperiod
--
ALTER TABLE "sentry_groupopenperiod" DROP COLUMN "event_id" CASCADE; |
Final migration to fully delete the column