Skip to content

Conversation

@shashjar
Copy link
Member

@shashjar shashjar commented Feb 9, 2026

Same changes as #107752, just separating backend & frontend changes.

Follow-up to #107893.

Part of ID-1333.

This PR displays the "Set Up Code Mapping" button from in-app stack frames on the issue details page for all platforms.

After changes:
image
image

@linear
Copy link

linear bot commented Feb 9, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 9, 2026
</ShowHideButton>
) : null}
<Flex>
<Flex align="center" gap="sm">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are so that:

  1. The "In App" badge remains vertically centered in the stack frame row
  2. There is some horizontal spacing between the "Set Up Code Mapping" button and the "In App" badge in each stack frame row

@shashjar shashjar requested a review from a team February 9, 2026 23:31
@shashjar shashjar marked this pull request as ready for review February 9, 2026 23:32
@shashjar shashjar requested a review from a team as a code owner February 9, 2026 23:32
@shashjar shashjar removed the request for review from a team February 9, 2026 23:32
shashjar added a commit that referenced this pull request Feb 10, 2026
…back to default frame info (#107893)

Same changes as #107752, just
separating backend & frontend changes.

Precursor to #107894.

Part of
[ID-1333](https://linear.app/getsentry/issue/ID-1333/enable-the-set-up-code-mapping-modal-from-issue-details-for-all).

The "Set Up Code Mapping" modal is different from the code mapping
config in the integration settings. The former takes the source code URL
for the file and attempts to derive what the source/stack root should
be; the latter just asks for that input directly.

To account for this, I modified
`src/sentry/issues/auto_source_code_config/frame_info.py` to not fail
for any "unsupported" platforms. The only effect of this will be that
there's no auto-suggested URL in the modal for native platforms, but
creating a code mapping will still work from there. No regression/change
in behavior for platforms that are already included in
`PLATFORMS_CONFIG`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants