ref(preprod): Add data_retention checks for all size analysis endpoint related reads #107891
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| cutoff = get_size_retention_cutoff(project.organization) | ||
| artifact = comparison_obj.head_size_analysis.preprod_artifact | ||
| if artifact.date_added < cutoff: | ||
| return Response({"detail": "This build's size data has expired."}, status=404) |
There was a problem hiding this comment.
Compare download only checks head artifact retention, not base
Medium Severity
The retention check in the compare download endpoint only validates the head artifact's date_added against the cutoff, while the sibling compare endpoint at project_preprod_size_analysis_compare.py correctly checks both head_artifact.date_added < cutoff or base_artifact.date_added < cutoff. If the base artifact's data has expired but the head hasn't, this endpoint will still serve the comparison data, bypassing the intended data retention policy.
Additional Locations (1)
1 participant
Closes EME-724