Skip to content

Conversation

@ceorourke
Copy link
Member

@ceorourke ceorourke commented Feb 9, 2026

Now that we've migrated the Action data to only ever have a sentry app id (and not an installation uuid) we can remove references to the sentry app identifier as it was only used to differentiate between actions with a sentry app id and actions with a sentry app installation uuid.

Closes ISWF-2034

@linear
Copy link

linear bot commented Feb 9, 2026

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 9, 2026
@ceorourke ceorourke marked this pull request as ready for review February 9, 2026 22:46
@ceorourke ceorourke requested a review from a team as a code owner February 9, 2026 22:46
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

sentryAppIdentifier === SentryAppIdentifier.SENTRY_APP_INSTALLATION_UUID &&
targetIdentifier === sentryApp?.installationUuid;
return isMatchingAppId || isMatchingInstallationUuid;
return targetIdentifier === sentryApp?.id;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Creating new Sentry App actions will fail because the frontend no longer sends the required sentry_app_identifier field, which the backend still expects for validation.
Severity: HIGH

Suggested Fix

Update the getDefaultConfig() function in automationBuilderContext.tsx to include the sentryAppIdentifier field in the returned configuration object for new Sentry App actions. This will align the frontend payload with the backend's required schema and allow new actions to be saved successfully.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/views/automations/components/actionNodeList.tsx#L51

Potential issue: When creating a new Sentry App action, the frontend configuration
generated by `getDefaultConfig()` in `automationBuilderContext.tsx` no longer includes
the `sentryAppIdentifier` field. However, the backend schema defined in
`sentry_app_handler.py` still lists `sentry_app_identifier` as a required field.
Consequently, any attempt to save a new Sentry App action from the user interface will
result in a backend validation error, preventing users from successfully creating these
automations.

Copy link
Member Author

@ceorourke ceorourke Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not be merged until #107174 is merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant