chore(preprod): Filter out mobile builds if any related size status is NOT_RAN #107885
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| queryset = queryset.annotate_platform_name() | ||
| queryset = queryset.exclude( | ||
| preprodartifactsizemetrics__state=PreprodArtifactSizeMetrics.SizeAnalysisState.NOT_RAN, | ||
| ) |
There was a problem hiding this comment.
Exclude filter leaks into quota/processing pipeline logic
High Severity
The NOT_RAN exclude added to queryset_for_query unintentionally affects the processing pipeline. queryset_for_query is also called by artifact_matches_query (used in quotas.py → should_run_feature), meaning artifacts with any NOT_RAN size metric will fail quota/filter checks for all features, not just display. In project_preprod_artifact_update.py, when size analysis is skipped, a NOT_RAN metric is created before should_run_distribution is called—so distribution gets incorrectly skipped too. Similarly, the rerun-analysis endpoint would fail to re-process artifacts that already have NOT_RAN metrics.
There was a problem hiding this comment.
I think this is OK for now. I think the AI is slightly wrong, but this change is basically only for presentation layer list cases, so it should not affect any actual running of logic
1 participant
Close https://linear.app/getsentry/issue/EME-801/hide-builds-with-not-ran-size-analysis-from-size-table